search

catapult-project / catapult

Deprecated Catapult GitHub. Please instead use http://crbug.com "Speed>Benchmarks" component for bugs and https://chromium.googlesource.com/catapult for downloading and editing source code..
https://chromium.googlesource.com/catapult
BSD 3-Clause "New" or "Revised" License
1.93k stars 564 forks source link

Histograms should be elided if there were failures #4376

Closed simonhatch closed 6 years ago

simonhatch commented 6 years ago

For chartjson, I think we don't generate the summary statistic if there are pages missing (is that right), but histograms will always create the summary from whatever pages happen to be there. What should we do here?

@eakuefner

eakuefner commented 6 years ago

We want to emulate the existing behavior, which is that if there are stories missing, we don't emit the histogram.

eakuefner commented 6 years ago

The plan here is to plumb had_failures through Telemetry info and just filter these out for now in add_reserved_diagnostics.