catapult-project / catapult

Deprecated Catapult GitHub. Please instead use http://crbug.com "Speed>Benchmarks" component for bugs and https://chromium.googlesource.com/catapult for downloading and editing source code..
https://chromium.googlesource.com/catapult
BSD 3-Clause "New" or "Revised" License
1.93k stars 564 forks source link

Dashboard - /add_histogram computes path for summary statistics incorrectly #4378

Closed simonhatch closed 6 years ago

simonhatch commented 6 years ago

https://chromeperf.appspot.com/report?sid=ba8b54a128bb7c2bab10aa5ea90710a4fbde619153d11eb3b8cff38d1d4ba20d

Right now we mash together all the story tags to form the summary's name, ie.:

ChromiumPerfFyi/histogram-diff-histograms-18/v8.browsing_desktop / blink-gc-complete-sweep / browse_media_news_search_social_tech

When it should just be:

ChromiumPerfFyi/histogram-diff-histograms-18/v8.browsing_desktop / blink-gc-complete-sweep

@eakuefner

simonhatch commented 6 years ago

I think we also don't generate any summary statistics across tir_labels?

Ie. ChromiumPerfFyi/histogram-diff-histograms-18/v8.browsing_desktop / blink-gc-complete-sweep / browse_media