Closed simonhatch closed 6 years ago
We need to set IS_SUMMARY for all the merged histograms to fix this bug.
More discussion offline with @simonhatch -- we don't need this, because there are no summaries across tags in chart JSON. Fixing #4387 will get rid of the histograms that we don't need because they're not present in chart JSON, and will add the histograms that we expect because they are present in chart JSON.
This has been fixed by the same fix for #4387
https://chromeperf.appspot.com/report?sid=41e8377ec2fcf5a655e4611925dda666f186b087d44426ddeaee4ac1e7b8db2b
Chartjson has both [cold, warm] under timeToFirstContentfulPaint_avg
ChromiumPerfFyi/histogram-diff-chartjson-20/loading.desktop / timeToFirstContentfulPaint_avg / cold
Whereas histograms seems to mash them together for some reason:
ChromiumPerfFyi/histogram-diff-histograms-20/loading.desktop / timeToFirstContentfulPaint / cold_warm
@eakuefner