search

catapult-project / catapult

Deprecated Catapult GitHub. Please instead use http://crbug.com "Speed>Benchmarks" component for bugs and https://chromium.googlesource.com/catapult for downloading and editing source code..
https://chromium.googlesource.com/catapult
BSD 3-Clause "New" or "Revised" License
1.93k stars 562 forks source link

Perf Dashboard: Updates don't get picked up #4384

Closed mariakhomenko closed 5 years ago

mariakhomenko commented 6 years ago

Chrome version: 58.0.3029.110 (Linux) URL: https://chromeperf.appspot.com/

Please copy and paste any errors from JavaScript console (Ctrl+Shift+J to open):

Please describe the problem:

  1. Select a benchmark, bot, and subtest, e.g. start_with_url.warm.startup_pages . Add graph on the page.
  2. Edit the benchmark name (e.g. go from start_with_url.warm.startup_pages to start_with_url.cold.startup_pages)
  3. Click add

Expected: Another graph for start_with_url.cold.startup_page is shown

Actual: A second copy of the original graph for start_with_url.warm.startup_pages is added to the screen even though the input box now says "cold" instead of "warm".

benshayden commented 6 years ago

Thanks for reporting! There's a trick to it: you need to click the option in the dropdown to actually change the benchmark. This is a known issue that I'm hoping V2SPA can clarify using checkboxes to indicate what options are selected. V2SPA doesn't allow editing the benchmark name exactly, but you can type a query like "cold" to filter the options. It's just a prototype, so there are lots of bugs, but can you confirm that V2SPA clarifies this interaction?

mariakhomenko commented 6 years ago

It's no longer possible to change the name in V2SPA since it disappears from the entry box when it's focused, so you certainly can't reproduce the same problem there.

One small feature request for V2SPA flow for the same flow though: it would be really helpful if the option dropdown was scrolled to the currently (or first if multiple) selected value when it's focused.

benshayden commented 5 years ago

https://bugs.chromium.org/p/chromium/issues/detail?id=892946