catapult-project / catapult

Deprecated Catapult GitHub. Please instead use http://crbug.com "Speed>Benchmarks" component for bugs and https://chromium.googlesource.com/catapult for downloading and editing source code..
https://chromium.googlesource.com/catapult
BSD 3-Clause "New" or "Revised" License
1.93k stars 564 forks source link

Histograms - No summary statistics for tir_labels #4387

Closed simonhatch closed 6 years ago

simonhatch commented 6 years ago

Moving this to it's own issue. Summary statistics are created for top level metrics, ie.

M/B/S/foo

but not for nested

M/B/S/foo/bar

@eakuefner

eakuefner commented 6 years ago

This has been broken out from #4378

eakuefner commented 6 years ago

This is actually not a bug, because we would expect summaries of the first form for benchmarks that do not use tags, and the second form for those that do.

eakuefner commented 6 years ago

This actually isn't fixed; the problem is that we don't emit summaries of the form M/B/S/foo/bar for benchmarks that use tags, because we currently don't consider tags when merging.

eakuefner commented 6 years ago

This is fixed.