catapult-project / catapult

Deprecated Catapult GitHub. Please instead use http://crbug.com "Speed>Benchmarks" component for bugs and https://chromium.googlesource.com/catapult for downloading and editing source code..
https://chromium.googlesource.com/catapult
BSD 3-Clause "New" or "Revised" License
1.93k stars 564 forks source link

Dashboard - Duplicate histograms coming out of add_reserved_diagnostics #4389

Closed simonhatch closed 6 years ago

simonhatch commented 6 years ago

Speaking with Ethan offline, these are because histogram storyTags coming out of telemetry actually contain a bunch of extra tags that the dashboard ignores. So merging is working properly, in that it's not merging 2 histograms with differing tags, but what we need it to do is ignore some tags.

ie.

h1 = ['case:browse', 'group:media'] h2 = ['case:browse', 'group:media', 'heavy_on_some_function']

On the dashboard, these both resolve to the same test path, so merging needs to take this into account. Perhaps the best thing would be to share the test path computation code with add_reserved_diagnostics, so there's no question as to where a histogram maps to.