Dashboard - Remove code/command_line from TestMetadata?

catapult-project / catapult

Deprecated Catapult GitHub. Please instead use http://crbug.com "Speed>Benchmarks" component for bugs and https://chromium.googlesource.com/catapult for downloading and editing source code..

https://chromium.googlesource.com/catapult

BSD 3-Clause "New" or "Revised" License

1.92k stars 564 forks source link

Dashboard - Remove code/command_line from TestMetadata? #4405

Closed simonhatch closed 6 years ago

simonhatch commented 6 years ago

I don't see any references in the code to these.

@anniesullie @eakuefner

anniesullie commented 6 years ago

Places it could be used:

Telling pinpoint which command to run
Telling CL authors how to reproduce locally

I'm skeptical that the current implementation is the best way to achieve either of these goals.

simonhatch commented 6 years ago

Yeah those could definitely be useful, but don't want to keep them around just in case we might use them. If they're not being used right now, I'd vote to delete them and add/re-add whatever we need once we've figured out what Pinpoint needs.

anniesullie commented 6 years ago

sgtm