Deprecated Catapult GitHub. Please instead use http://crbug.com "Speed>Benchmarks" component for bugs and https://chromium.googlesource.com/catapult for downloading and editing source code..
In the process of fixing #4397 I noticed that trace URLs are also broken. We handle these in a more straightforward way, so the fix is not the same. In particular (thanks @benshayden for help with this investigation), we assume wrongly that there will be only one trace URL, which is incorrect because there are often multiple, due to story repeats.
Chart JSON actually does a wrong thing here also, which I remember people complaining about in the past. Because it produces a dict and just iterates over values in order, all trace URLs except the one from the last repeat, per-story, get clobbered. So we can do the same thing here, and just pick the last element of the GenericSet to store as a_tracing_uri.
eakuefner
commented
6 years ago
In the process of fixing #4397 I noticed that trace URLs are also broken. We handle these in a more straightforward way, so the fix is not the same. In particular (thanks @benshayden for help with this investigation), we assume wrongly that there will be only one trace URL, which is incorrect because there are often multiple, due to story repeats.
Chart JSON actually does a wrong thing here also, which I remember people complaining about in the past. Because it produces a dict and just iterates over values in order, all trace URLs except the one from the last repeat, per-story, get clobbered. So we can do the same thing here, and just pick the last element of the
GenericSetto store asa_tracing_uri.