catapult-project / catapult

Deprecated Catapult GitHub. Please instead use http://crbug.com "Speed>Benchmarks" component for bugs and https://chromium.googlesource.com/catapult for downloading and editing source code..
https://chromium.googlesource.com/catapult
BSD 3-Clause "New" or "Revised" License
1.92k stars 564 forks source link

<histogram-json> in results.html needs escaping #4415

Closed jeremyroman closed 6 years ago

jeremyroman commented 6 years ago

One of the benchmarks in Chromium (speedometer2) has the string "<regex>" in its description, and this prevents it from loading, because the part of Catapult that tries to extract and parse JSON from gets confused.

The JSON should probably be HTML-escaped before putting it inside a tag.

simonhatch commented 6 years ago

@benshayden