Dashboard - Still need set_warning_message?

catapult-project / catapult

Deprecated Catapult GitHub. Please instead use http://crbug.com "Speed>Benchmarks" component for bugs and https://chromium.googlesource.com/catapult for downloading and editing source code..

https://chromium.googlesource.com/catapult

BSD 3-Clause "New" or "Revised" License

1.92k stars 564 forks source link

Dashboard - Still need set_warning_message? #4418

Closed simonhatch closed 6 years ago

simonhatch commented 6 years ago

I just found this, never saw it before and don't recall ever seeing a warning on the dashboard. Should we keep this?

@eakuefner @anniesullie

anniesullie commented 6 years ago

The original idea was that it could be used to inform users of outages (bisect is down for these bots, perf dashboard isn't showing this data, perf waterfall is having an outage). It hasn't been used for that purpose in at least 2 years.

I think we should remove it, and re-implement in the UI if we see a need for it later.