search

catapult-project / catapult

Deprecated Catapult GitHub. Please instead use http://crbug.com "Speed>Benchmarks" component for bugs and https://chromium.googlesource.com/catapult for downloading and editing source code..
https://chromium.googlesource.com/catapult
BSD 3-Clause "New" or "Revised" License
1.92k stars 564 forks source link

Dashboard - oauth2_decorator and api_auth #4419

Closed simonhatch closed 5 years ago

simonhatch commented 6 years ago

Have 2 ways for oauth right now, wonder if we can merge these.

@eakuefner @anniesullie

benshayden commented 6 years ago

V2SPA currently copies pinpoint's use of the google-signin component, which works with api_auth but not oauth2_decorator, iiuc.

oauth2_decorator is currently only used by associate_alerts, bug_detail, file_bug. V2SPA currently merges that functionality into /api/alerts, so oauth2_decorator and its callers can simply be deleted when the V1 UI is removed.

simonhatch commented 6 years ago

Oh neat, so I'll leave this alone then :)

benshayden commented 5 years ago

Closing: I don't think we'll forget to remove legacy code when v2spa is stable.