search

catapult-project / catapult

Deprecated Catapult GitHub. Please instead use http://crbug.com "Speed>Benchmarks" component for bugs and https://chromium.googlesource.com/catapult for downloading and editing source code..
https://chromium.googlesource.com/catapult
BSD 3-Clause "New" or "Revised" License
1.92k stars 564 forks source link

[wpr-go] replay mode does not use recorded time in deterministic.js #4434

Closed spelchat closed 6 years ago

spelchat commented 6 years ago

This commit change deterministic.js to use the current time rather than a fixed time as a seed: https://github.com/catapult-project/catapult/commit/677b02eacd6fe0d32040649858b5248d7dc402da

This makes sense for the record mode of WPR. But I think the seed should be saved in the archive. The replay mode should use the saved seed rather than the current time.