Problems with highlighting in the new color scheme

catapult-project / catapult

Deprecated Catapult GitHub. Please instead use http://crbug.com "Speed>Benchmarks" component for bugs and https://chromium.googlesource.com/catapult for downloading and editing source code..

https://chromium.googlesource.com/catapult

BSD 3-Clause "New" or "Revised" License

1.92k stars 564 forks source link

Problems with highlighting in the new color scheme #4446

Open vnoe opened 6 years ago

vnoe commented 6 years ago

When the new color scheme was introduced, the highlighting got messed up. For some colors highlighting is almost invisible and for some other colors it is to dark to read the text. Changing the lighten-function in tracing/tracing/base/color.html to something like

lighten(k) {
      const hsl = this.toHSL();
      hsl.l = hsl.l * (1 - k) + k;
      return Color.fromHSL(hsl);
      }

would improve the visibility of highlighted entries.

benshayden commented 6 years ago

Thanks! @fmeawad @lpy @hashseed PTAL?

fmeawad commented 6 years ago

@hashseed I personally found that calling the brighten method works better, maybe we should merge the two methods?

hashseed commented 6 years ago

Sounds good. I can work on that as soon as I return from vacation in two weeks :)