search

catapult-project / catapult

Deprecated Catapult GitHub. Please instead use http://crbug.com "Speed>Benchmarks" component for bugs and https://chromium.googlesource.com/catapult for downloading and editing source code..
https://chromium.googlesource.com/catapult
BSD 3-Clause "New" or "Revised" License
1.91k stars 563 forks source link

Perf dashboard should provide a better bisect experience when not logged in #4455

Open zeptonaut opened 6 years ago

zeptonaut commented 6 years ago

A few times, I've had the frustrating experience of navigating to a given test path, clicking on a data point, and filling in the bisect info only to notice that the "Story filter" field isn't filled in. This is indicative of a bigger problem: I'm not logged in.

In order to prevent this frustration, it'd be great if the dashboard prevented the user from launching a bisect when not logged in, instead popping up a window when they try that says "You must be logged in to launch a bisect" or something like that.

simonhatch commented 6 years ago

@benshayden for v2spa

I think nav-bar knows the sign-in status, so we should be able to plumb that through to the bisect-button