search

catapult-project / catapult

Deprecated Catapult GitHub. Please instead use http://crbug.com "Speed>Benchmarks" component for bugs and https://chromium.googlesource.com/catapult for downloading and editing source code..
https://chromium.googlesource.com/catapult
BSD 3-Clause "New" or "Revised" License
1.91k stars 563 forks source link

[🔊] Soundwave fails when downloading alerts for a benchmark with no alerts #4477

Closed zeptonaut closed 6 years ago

zeptonaut commented 6 years ago

The failure stack trace is:

Traceback (most recent call last):
  File "bin/soundwave", line 96, in <module>
    Main()
  File "bin/soundwave", line 88, in Main
    commands.FetchAlertsData(args)
  File "./soundwave/commands.py", line 30, in FetchAlertsData
    api.GetAlertData(args.benchmark, args.days))
  File "./soundwave/tables/alerts.py", line 63, in DataFrameFromJson
    index=INDEX, columns=COLUMNS)
  File "/usr/local/google/home/charliea/.local/lib/python2.7/site-packages/pandas/core/frame.py", line 1229, in from_records
    return cls(index=index, columns=columns)
  File "/usr/local/google/home/charliea/.local/lib/python2.7/site-packages/pandas/core/frame.py", line 348, in __init__
    mgr = self._init_dict(data, index, columns, dtype=dtype)
  File "/usr/local/google/home/charliea/.local/lib/python2.7/site-packages/pandas/core/frame.py", line 441, in _init_dict
    index = _ensure_index(index)
  File "/usr/local/google/home/charliea/.local/lib/python2.7/site-packages/pandas/core/indexes/base.py", line 4957, in _ensure_index
    return Index(index_like)
  File "/usr/local/google/home/charliea/.local/lib/python2.7/site-packages/pandas/core/indexes/base.py", line 425, in __new__
    cls._scalar_data_error(data)
  File "/usr/local/google/home/charliea/.local/lib/python2.7/site-packages/pandas/core/indexes/base.py", line 883, in _scalar_data_error
    repr(data)))
TypeError: Index(...) must be called with a collection of some kind, 'key' was passed

I have a fix for this locally that I'll send out.

/cc @perezju