search

catapult-project / catapult

Deprecated Catapult GitHub. Please instead use http://crbug.com "Speed>Benchmarks" component for bugs and https://chromium.googlesource.com/catapult for downloading and editing source code..
https://chromium.googlesource.com/catapult
BSD 3-Clause "New" or "Revised" License
1.91k stars 563 forks source link

Pinpoint - New job dialog bot dropdown is empty #4496

Closed simonhatch closed 6 years ago

simonhatch commented 6 years ago

Reported by rsesek

@dave-2

dave-2 commented 6 years ago

I had moved the configs from public to internal for the upcoming move to chrome-swarming. I can put it back but we'll need to figure out some way to do external/internal. It's probably fine if the configuration list is external, but we need to ensure only internal users can kick off jobs. Filed #4497.

simonhatch commented 6 years ago

Can you not do a check on the user and return the appropriate bot list, and/or grey out the new job button when they don't have permission?

dave-2 commented 6 years ago

Yes, but for external users, the list is empty. So would it be WAI?

simonhatch commented 6 years ago

Maybe we can grey out the button or do something to indicate they're not logged in/don't have permission.

dave-2 commented 6 years ago

We can do that. --> #4497