search

catapult-project / catapult

Deprecated Catapult GitHub. Please instead use http://crbug.com "Speed>Benchmarks" component for bugs and https://chromium.googlesource.com/catapult for downloading and editing source code..
https://chromium.googlesource.com/catapult
BSD 3-Clause "New" or "Revised" License
1.91k stars 563 forks source link

[📍] Job terminated and reported a difference earlier than needed #4501

Closed sanekspot closed 6 years ago

sanekspot commented 6 years ago

This job tested only two commits: 532803 and 533628 and reported that the last one is a culptrit without testing anything between these commits.

https://pinpoint-dot-chromeperf.appspot.com/job/12d77e01240000

simonhatch commented 6 years ago

@dave-2 Any idea what's going on here? From a glance, the commit positions are 800 apart.

simonhatch commented 6 years ago

For reference, think this for crbug.com/809509

dave-2 commented 6 years ago

Not sure what happened here. I deployed a fresh dashboard and put this code into the dev console. It continued running as expected, adding an additional commit to the list. I don't think there were any changes in this area recently, so that would imply some kind of transient error.

from dashboard.pinpoint.models import job
j = job.JobFromId('12d77e01240000')
j.Run()
simonhatch commented 6 years ago

That's really strange, since it commented on the bug, it presumably thought it was done.

dave-2 commented 6 years ago

Yes, that means it did detect a difference, but was unable to take the midpoint between the two commits. Maybe Gitiles produced an empty commit range or some other unexpected output?

dave-2 commented 6 years ago

https://chromium-review.googlesource.com/c/catapult/+/1093724