search

catapult-project / catapult

Deprecated Catapult GitHub. Please instead use http://crbug.com "Speed>Benchmarks" component for bugs and https://chromium.googlesource.com/catapult for downloading and editing source code..
https://chromium.googlesource.com/catapult
BSD 3-Clause "New" or "Revised" License
1.91k stars 563 forks source link

[🔊] Soundwave should check for credentials before starting worker pool #4503

Closed perezju closed 6 years ago

perezju commented 6 years ago

To reproduce the problem (how it happened to me):

  1. Checkout catapult repository on a new machine.
  2. Run bin/soundwave timeseries -i test_paths.txt
  3. The main process doesn't need to make any API calls, so it never creates the dashboard communicator.
  4. Lots of subprocesses launched to fetch the test paths in the file!
  5. But there are no credentials stored on the machine!
  6. Each subprocess creates a dashboard communicator, they notice the missing credentials, so the automagic method to gather credentials kicks in ...
  7. ... so lots and lots of Chrome tabs are created all asking you to provide credentials!

And somehow Ctrl+C just caused more tabs to be created :unamused:

@zeptonaut