catapult-project / catapult

Deprecated Catapult GitHub. Please instead use http://crbug.com "Speed>Benchmarks" component for bugs and https://chromium.googlesource.com/catapult for downloading and editing source code..
https://chromium.googlesource.com/catapult
BSD 3-Clause "New" or "Revised" License
1.93k stars 563 forks source link

android_platform_backend: PushProfile should be smarter about filtering 'lib' #4510

Open csharrison opened 6 years ago

csharrison commented 6 years ago

Right now we iterate through the host profile and filter out top-level files that are named 'lib'. This misses directories named lib.

Instead of filtering these files out, we should just raise an exception, since the caller probably wants to know about this issue rather than silently omitting important files.

csharrison commented 6 years ago

https://chromium-review.googlesource.com/1093557