search

catapult-project / catapult

Deprecated Catapult GitHub. Please instead use http://crbug.com "Speed>Benchmarks" component for bugs and https://chromium.googlesource.com/catapult for downloading and editing source code..
https://chromium.googlesource.com/catapult
BSD 3-Clause "New" or "Revised" License
1.93k stars 563 forks source link

Rename and Remove runs from results2.html #4513

Open fmeawad opened 6 years ago

fmeawad commented 6 years ago

Many times when running experiments locally, the experiment is run with and without a flag. In the old results.html, we were able to rename certain runs (by giving them a more descriptive name rather than the benchmark name + timestamp).

I don't seem to be able to find that functionality in the new system.

Another useful feature is deleting runs, if a run fails for some reason, you either end up with an empty result, or --reset the whole experiment. Deleting runs would allow retrying specific runs.

fmeawad commented 6 years ago

I found a --results-label= which can be added during the run, which is useful, but if forgotten, there is no way to fix it later.

benshayden commented 6 years ago

Thanks for reporting! My best idea for how to handle this is to add support for a few new URL hash params to remove columns or dynamically re-label Histograms. Some new UI could allow editing column headings. Alternatively, a script could be added to tracing/bin to edit Histograms and re-vulcanize. Unfortunately, results2 is in maintenance mode at the moment while I'm focusing on V2SPA. Let me know if this is blocking you and I can squeeze it in, otherwise I'll keep this open on the backlog for now.