search

catapult-project / catapult

Deprecated Catapult GitHub. Please instead use http://crbug.com "Speed>Benchmarks" component for bugs and https://chromium.googlesource.com/catapult for downloading and editing source code..
https://chromium.googlesource.com/catapult
BSD 3-Clause "New" or "Revised" License
1.93k stars 564 forks source link

[📍] Allow providing a CL for catapult too #4529

Open sadrulhc opened 6 years ago

sadrulhc commented 6 years ago

pinpoint currently allow specifying a single gerrit URL, which allows running with changes only to the chromium repo. Often times, it is desirable to run a perf-job that requires changes in both chromium code (whose impact we want to test, or something that adds/removes/updates trace events), and in catapult code (to update the corresponding measurement in telemetry/tracing). It would be really quite awesome if pinpoint had this support to provide a CL for chromium and at the same time also provide a CL for catapult. (https://ct.skia.org/chromium_perf/ has this capability, which has been quite useful too)

Thank you!

dave-2 commented 6 years ago

Perf try jobs are implemented as an A/B test. So the Chromium patch is applied to only B, and not A. In this scenario, you want the Catapult patch to be applied to both A and B, right?

dave-2 commented 6 years ago

Also blocking on chromium issue 820653.

sadrulhc commented 6 years ago

I think applying the catapult patch only for B run would also be useful, but yes, if it's applied in both A and B runs, that would also work.