catapult-project / catapult

Deprecated Catapult GitHub. Please instead use http://crbug.com "Speed>Benchmarks" component for bugs and https://chromium.googlesource.com/catapult for downloading and editing source code..
https://chromium.googlesource.com/catapult
BSD 3-Clause "New" or "Revised" License
1.91k stars 563 forks source link

chartjson2historgrams chokes on json output from builders #4536

Closed perezju closed 4 years ago

perezju commented 6 years ago

The chartjson on (legacy) builders wraps the entire chartjson data in an extra dict of the form:

{
  "bot": "builder_name",
  "chart_data": {
    // actual chartjson
  }
  "is_ref": false,
  "master": "master_name",
  "point_id": 1530687268,
  "test_suite_name": "benchmark.name",
  ...
}

So running chartjson2historgrams.py on this breaks with:

RuntimeError: Exception raised when executing /tmp/tmpqqZ_Gr/_tmp_boostrap.js:
/tracing/value/chart_json_converter.html:23: TypeError: Cannot read property 'trace' of undefined
      const traceValues = charts.charts.trace;
                                       ^
TypeError: Cannot read property 'trace' of undefined

It would be neat if the script worked out of the box with these json files too.

perezju commented 4 years ago

Closing as obsolete.