catapult-project / catapult

Deprecated Catapult GitHub. Please instead use http://crbug.com "Speed>Benchmarks" component for bugs and https://chromium.googlesource.com/catapult for downloading and editing source code..
https://chromium.googlesource.com/catapult
BSD 3-Clause "New" or "Revised" License
1.91k stars 563 forks source link

Perf Dashboard V2: Iterating through groups of alerts via hotkeys #4547

Closed tdresser closed 5 years ago

tdresser commented 5 years ago

As the sheriff, I'm generally going through groups consecutively.

The current workflow tries to be very order agnostic, but if it was a bit more opinionated, it could potentially much more efficient.

Suppose we have a "show the next group" button. Maybe also a keyboard shortcut. Perhaps we speculatively prefetch the graphs for the next n groups as well.

Maybe add some keyboard shortcuts for "Invalid" and "New Bug". Maybe those keyboard shortcuts even auto-advance to the next group?

I can imagine getting to the point where much of the sheriffing process is just hitting a button, once per group, which either marks the current group as invalid and then advances to the next group, or files a new bug and advances the next group.


These thoughts brought to you by the 1500 alert shift I just had.

simonhatch commented 5 years ago

Yes! I was bugging Ben for something similar, a power-user mode that just lets you burn through them quickly.

benshayden commented 5 years ago

Keyboard shortcuts are on go/chromeperf-v2-status. I'll bump them up!

tdresser commented 5 years ago

I think the speculative prefetch thing could be pretty important here. A lot of my workflow right now revolves around getting the right graphs loading, especially for groups with large numbers of alerts.

Hard to say though.

benshayden commented 5 years ago

Moved to crbug