search

catapult-project / catapult

Deprecated Catapult GitHub. Please instead use http://crbug.com "Speed>Benchmarks" component for bugs and https://chromium.googlesource.com/catapult for downloading and editing source code..
https://chromium.googlesource.com/catapult
BSD 3-Clause "New" or "Revised" License
1.91k stars 563 forks source link

[📍] Pinpoint Jobs failed on Android Nexus5X WebView Perf #4556

Closed dave-2 closed 5 years ago

dave-2 commented 5 years ago

Looks like we were using a case-sensitive compare to detect whether to run performance_test_suite or performance_webview_test_suite. So all jobs with the new bot name failed with "Pinpoint can't find the isolate hash."

https://pinpoint-dot-chromeperf.appspot.com/job/169c8c0ea40000 https://pinpoint-dot-chromeperf.appspot.com/job/16db84c1a40000 https://pinpoint-dot-chromeperf.appspot.com/job/15fe51dea40000 https://pinpoint-dot-chromeperf.appspot.com/job/148c2e36a40000 https://pinpoint-dot-chromeperf.appspot.com/job/11a04aa6a40000 https://pinpoint-dot-chromeperf.appspot.com/job/14b20f39a40000 https://pinpoint-dot-chromeperf.appspot.com/job/14886436a40000

dave-2 commented 5 years ago

Also failed: https://pinpoint-dot-chromeperf.appspot.com/job/14b67cb9a40000 https://pinpoint-dot-chromeperf.appspot.com/job/14af7fa9a40000 https://pinpoint-dot-chromeperf.appspot.com/job/16fc43d5a40000 https://pinpoint-dot-chromeperf.appspot.com/job/12af1ae1a40000 https://pinpoint-dot-chromeperf.appspot.com/job/12b06c85a40000

Fix is in and deployed, here's the first passing job: https://pinpoint-dot-chromeperf.appspot.com/job/16b06c85a40000

dave-2 commented 5 years ago

I've re-run all the failed jobs, and confirmed that they ran with performance_webview_test_suite Yay!