catapult-project / catapult

Deprecated Catapult GitHub. Please instead use http://crbug.com "Speed>Benchmarks" component for bugs and https://chromium.googlesource.com/catapult for downloading and editing source code..
https://chromium.googlesource.com/catapult
BSD 3-Clause "New" or "Revised" License
1.91k stars 563 forks source link

Pinpoint: Red X makes it look like failure #4558

Closed npm1 closed 5 years ago

npm1 commented 5 years ago

What's the meaning of the red X in the histograms? Is it just that we're not measuring a specific metric, so there are no applicable histograms to show? In the example below the job passed all runs but I was unsure because the X made it look like a failure:

https://pinpoint-dot-chromeperf.appspot.com/job/14cda53ea40000

simonhatch commented 5 years ago

@dave-2

dave-2 commented 5 years ago

Sorry about that! The red X doesn't have a meaning in this case, and is just a bug. It will be fixed as part of a larger chart rewrite this quarter.

dave-2 commented 5 years ago

Fixed!