search

catapult-project / catapult

Deprecated Catapult GitHub. Please instead use http://crbug.com "Speed>Benchmarks" component for bugs and https://chromium.googlesource.com/catapult for downloading and editing source code..
https://chromium.googlesource.com/catapult
BSD 3-Clause "New" or "Revised" License
1.91k stars 563 forks source link

[📍] Executions comparison UI #4560

Closed dave-2 closed 5 years ago

dave-2 commented 5 years ago

Problem

For perf try jobs with no comparison_mode, the chart on the page doesn't show any useful information, because there's no defined metric to look at.

screen shot 2018-07-19 at 11 06 27 am

Even pass/fail information is better served by the more detailed execution view below it. The only reason we have the chart is so users can click on the points to navigate between the execution details of the two changes.

Proposed solution

Change the execution details view into a side-by-side comparison view of two adjacent executions. For a bisect job, it will show the currently selected change on the right, and the previous change on the left.

We'll want to re-layout the execution details to make it fit horizontally and make it easier to understand. I'll come up with a prototype for this as well.

@perezju @simonhatch

perezju commented 5 years ago

Yes! This would be great.

dave-2 commented 5 years ago

Done!