search

catapult-project / catapult

Deprecated Catapult GitHub. Please instead use http://crbug.com "Speed>Benchmarks" component for bugs and https://chromium.googlesource.com/catapult for downloading and editing source code..
https://chromium.googlesource.com/catapult
BSD 3-Clause "New" or "Revised" License
1.91k stars 563 forks source link

[📍] Run a try job dialog includes deprecated bots #4561

Closed perezju closed 5 years ago

perezju commented 5 years ago

For example it includes both Android Nexus5 Perf and android-nexus5.

@dave-2 @simonhatch

dave-2 commented 5 years ago

Users may still want to run jobs on the old names for a few weeks after the name is deprecated, so we still support the old names. I would feel comfortable with removing the old names after the perf dashboard data migration (chromium:865998)

perezju commented 5 years ago

So I'm confused. What happens today if I run a job under an old name? Does something different happen if I run the same job under the new name?

dave-2 commented 5 years ago

It's the exact same thing. They're just additional aliases.

The perf dashboard treats them as separate bots, so when sheriffs triage alerts, they may still kick off bisects on the old names. So we need to support that.

perezju commented 5 years ago

So I get we need to support both names on incoming requests from other tools.

But the UI for humans to select something from the dialog is just confusing. I think we should only show the new names there. (Even if a human was looking at an old name on the perf dashboard, they will easily figure out the right bot to pick on the list with new names.)

simonhatch commented 5 years ago

+1 let's just show the latest of each, or at the very least just one of each.

dave-2 commented 5 years ago

Done!

perezju commented 5 years ago

I'm still seeing a mixture of old/new names in https://pinpoint-dot-chromeperf.appspot.com/ maybe I just need to wait for changes to be pushed? Btw, is there a way to get notifications when that happens?

dave-2 commented 5 years ago

No, I deployed right after landing, so the changes should already have taken effect. Note that the current names on the perf waterfall are inconsistent, with some having capitals/spaces, and others having lowercase/dashes.

Notifications: not yet. We're going to work with ChOps FE in Q4 to more standardize our deployment practices. Ideally, we will even have "deploy on green", automatic deployments when the tests pass.

perezju commented 5 years ago

Ah, you are right, I think I got confused between the Android Nexus5 Perf and android-nexus5x-perf (missed the extra x!).

Sorry for the noise.