search

catapult-project / catapult

Deprecated Catapult GitHub. Please instead use http://crbug.com "Speed>Benchmarks" component for bugs and https://chromium.googlesource.com/catapult for downloading and editing source code..
https://chromium.googlesource.com/catapult
BSD 3-Clause "New" or "Revised" License
1.91k stars 563 forks source link

Have cloud_storage.py use swarming credentials? #4563

Closed simonhatch closed 5 years ago

simonhatch commented 5 years ago

https://cs.chromium.org/chromium/src/third_party/catapult/common/py_utils/py_utils/cloud_storage.py?q=cloud_storage.py&sq=package:chromium&g=0&l=131

So trying to get the luci try server running, think we're down to a gsutil auth issue from the dependancy manager. Specifically, we seem to overwrite the env vars here in cloud_storage.py before calling gsutil. On the swarming bot, we have boto credentials in an env var, is there any way we can just use those? ie. check for SWARMING_HEADLESS: 1 and copy the env like the cros path?

@nedn

simonhatch commented 5 years ago

@zeptonaut Also touched the file at some point

simonhatch commented 5 years ago

Anybody opposed to me putting up a CL that checks for SWARMING_HEADLESS (an env var that swarming sets), and if that's set just use the current env vars?

nedn commented 5 years ago

Nope.

simonhatch commented 5 years ago

Long done.