catapult-project / catapult

Deprecated Catapult GitHub. Please instead use http://crbug.com "Speed>Benchmarks" component for bugs and https://chromium.googlesource.com/catapult for downloading and editing source code..
https://chromium.googlesource.com/catapult
BSD 3-Clause "New" or "Revised" License
1.91k stars 563 forks source link

[📍] Assign performance bug to the largest bad regression #4564

Closed npm1 closed 5 years ago

npm1 commented 5 years ago

Currently, Pinpoint tests the patches and looks for significant differences. Then I think it assigns the bug to the owner of the latest patch causing a difference. It doesn't even consider whether it's a good difference (move towards better number) or a bad difference (move towards worse number). I propose it should instead assign to the owner of the patch causing the worst bad difference. Or at the very least to the owner of the latest patch that causes a bad difference. In this example, it was assigned to a patch with a good difference:

https://bugs.chromium.org/p/chromium/issues/detail?id=866084#c3

simonhatch commented 5 years ago

Dupe of #4123