search

catapult-project / catapult

Deprecated Catapult GitHub. Please instead use http://crbug.com "Speed>Benchmarks" component for bugs and https://chromium.googlesource.com/catapult for downloading and editing source code..
https://chromium.googlesource.com/catapult
BSD 3-Clause "New" or "Revised" License
1.91k stars 563 forks source link

Add flow support for ftrace #4576

Closed trainman419 closed 5 years ago

trainman419 commented 5 years ago

I'm not sure if I've done this right, but I wanted to trace the usage of a few of the file locks in my program, so I added flow tracing support to the ftrace viewer.

I read through the trace even format specification but it's not clear how that is associated with the format of ftrace markers, so I mostly copied the format from the async markers.

The format says that flow events should be associated with slices. I get weird rendering artifacts if they're not associated with async slices, so I add async slices when I add each flow event. I'm not sure if this is entirely right, but it seems easier for both the data association and the trace marker logging.

benshayden commented 5 years ago

Please see the contributor's guide to upload changes to gerrit for review instead of pull requests.

trainman419 commented 5 years ago

Finally got this uploaded to gerrit: https://chromium-review.googlesource.com/c/catapult/+/1195006