Cannot upload CL

[trainman419]

I submitted a PR but it was rejected ( https://github.com/catapult-project/catapult/pull/4576 ) so I'm trying to upload a new CL to gerrit by following https://github.com/catapult-project/catapult/blob/master/CONTRIBUTING.md

I tried to follow the depot_tools installation link from the contributing guide, but there's not much there: https://www.chromium.org/developers/how-tos/install-depot-tools so I ended up following http://commondatastorage.googleapis.com/chrome-infra-docs/flat/depot_tools/docs/html/depot_tools_tutorial.html#_setting_up instead.

I've checked out the depot_tools repository and set up my path, and the gclient and git-cl tools are on my path and runnable.

I've configured by git username and email address, autoclrf and filemode settings as per the setup depot_tools setup instructions.

When I run gclient sync from a checkout of catapult, I get the following error:

$ gclient sync
Error: client not configured; see 'gclient config'

The instructions do not explain what setup or sync this might be performing, so I cannot evaluate if it is relevant or not.

The first time I ran git cl upload from my checkout of catapult, I got the following error:

$ git cl upload
WARNING: Your metrics.cfg file was invalid or nonexistent. A new one will been created.
Credentials for the following hosts are required:
  -review

These are read from /home/austin/.gitcookies (or legacy /home/austin/.netrc)
You can (re)generate your credentials by visiting https://-review/new-password

Subsequent runs produce a similar error, but without the warning about metrics.cfg

It seems like there is some configuration for git-cl that is missing, but neither the contributing guide nor the depot_tools setup instructions describe what it might be or how to set it.

[benshayden]

Catapult does not use gclient, and don't worry about the metrics.cfg. What does git remote show origin say? It should contain https://chromium.googlesource.com/catapult If not, try running git remote set-url origin https://chromium.googlesource.com/catapult and then try git cl upload again.

[trainman419]

I forked from github and I cannot upload new branches to github or https://chromium.googlesource.com/catapult , so I've had my origin to my own fork:

$ git remote -v
origin  git@github.com:trainman419/catapult.git (fetch)
origin  git@github.com:trainman419/catapult.git (push)
upstream    https://github.com/catapult-project/catapult.git (fetch)
upstream    https://github.com/catapult-project/catapult.git (push)

I've reset my upstream to https://chromium.googlesource.com/catapult and I can fetch from that repository, but git-cl still fails:

$ git remote -v
github  git@github.com:trainman419/catapult.git (fetch)
github  git@github.com:trainman419/catapult.git (push)
origin  https://chromium.googlesource.com/catapult (fetch)
origin  https://chromium.googlesource.com/catapult (push)
$ git cl upload
Credentials for the following hosts are required:
  -review

These are read from /home/austin/.gitcookies (or legacy /home/austin/.netrc)
You can (re)generate your credentials by visiting https://-review/new-password

If I completely remove my fork as an upstream, I get:

$ git remote -v
origin  https://chromium.googlesource.com/catapult (fetch)
origin  https://chromium.googlesource.com/catapult (push)
$ git cl upload
Credentials for the following hosts are required:
  chromium-review.googlesource.com
  chromium.googlesource.com
These are read from /home/austin/.gitcookies (or legacy /home/austin/.netrc)
You can (re)generate your credentials by visiting https://chromium-review.googlesource.com/new-password

After following that link to set up a googlesource account, I was finally able to make some progress with git-cl. (I'm failing presubmit checks now, but that looks like it's actually the result of my changes).

[trainman419]

Passed presubmit, got my CL uploaded to gerrit: https://chromium-review.googlesource.com/c/catapult/+/1195006

Thanks for your help!