catapult-project / catapult

Deprecated Catapult GitHub. Please instead use http://crbug.com "Speed>Benchmarks" component for bugs and https://chromium.googlesource.com/catapult for downloading and editing source code..
https://chromium.googlesource.com/catapult
BSD 3-Clause "New" or "Revised" License
1.91k stars 563 forks source link

Improve WASD keybinding for lefties and for french keyboard layout #4592

Closed oleveau closed 5 years ago

oleveau commented 5 years ago

As described in issue #527 WASD navigation is broken for non-qwerty keyboard.

I added some keybinding so that it also works with french keyboard layout (azerty), and add IJKL for lefties.

googlebot commented 5 years ago

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

:memo: Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers
oleveau commented 5 years ago

I signed it!

googlebot commented 5 years ago

CLAs look good, thanks!

benshayden commented 5 years ago

Please use git cl upload as described in CONTRIBUTING.md, thanks!