search

catapult-project / catapult

Deprecated Catapult GitHub. Please instead use http://crbug.com "Speed>Benchmarks" component for bugs and https://chromium.googlesource.com/catapult for downloading and editing source code..
https://chromium.googlesource.com/catapult
BSD 3-Clause "New" or "Revised" License
1.91k stars 563 forks source link

soundwave: pinpoint-cli crashes for windows bots #4594

Open sadrulhc opened 5 years ago

sadrulhc commented 5 years ago

Trying to get csv results for rendering.desktop bots fails with the following:

Traceback (most recent call last): File "./experimental/soundwave/bin/pinpoint_cli", line 72, in sys.exit(main()) File "./experimental/soundwave/bin/pinpoint_cli", line 56, in main return commands.DownloadJobResultsAsCsv(api, args.job_ids, args.output) File "experimental/soundwave/pinpoint_cli/commands.py", line 28, in DownloadJobResultsAsCsv histograms = api.isolate.RetrieveFile(isolate_hash, results_file) File "experimental/soundwave/services/isolate_service.py", line 37, in RetrieveFile return self.Retrieve(container['files'][filename]['h']) KeyError: u'rendering.desktop/perf_results.json'

@perezju

perezju commented 5 years ago

Yes, it's because of this TODO. :stuck_out_tongue:

I'll send out a CL to fix this. Thanks for using pinpoint_cli!