search

catapult-project / catapult

Deprecated Catapult GitHub. Please instead use http://crbug.com "Speed>Benchmarks" component for bugs and https://chromium.googlesource.com/catapult for downloading and editing source code..
https://chromium.googlesource.com/catapult
BSD 3-Clause "New" or "Revised" License
1.91k stars 563 forks source link

[traceviewer] Add the ability to select all events of a certain name from search #4597

Open nathanrogersgoogle opened 5 years ago

nathanrogersgoogle commented 5 years ago

The current flow of having to drag a box around a region that is known to contain all the events, and then selecting their name from the grouped list of events at the bottom of the screen, is a bit more painful than it needs to be. A "Select All" option somewhere near the search bar would help with this.

benshayden commented 5 years ago

You can add a toolbar-button to the find-control that calls a new method on its FindController that just calls this.brushingStateController_.findFocusChangedTo(new tr.model.EventSet(this.filterHits)).

https://github.com/catapult-project/catapult/blob/master/tracing/tracing/ui/find_control.html https://github.com/catapult-project/catapult/blob/master/tracing/tracing/ui/find_controller.html