catapult-project / catapult

Deprecated Catapult GitHub. Please instead use http://crbug.com "Speed>Benchmarks" component for bugs and https://chromium.googlesource.com/catapult for downloading and editing source code..
https://chromium.googlesource.com/catapult
BSD 3-Clause "New" or "Revised" License
1.91k stars 562 forks source link

Output of RunShellCommand with large_output=True missing when an error occurs #4631

Closed andrey-malets closed 5 years ago

andrey-malets commented 5 years ago

handle_large_output redirects large command output to temporary file, and if the command fails, resulting AdbShellCommandFailedError does not contain that output, but instead has an empty string in .output.

andrey-malets commented 5 years ago

Fixed in f48ed7d31e4728