search

catapult-project / catapult

Deprecated Catapult GitHub. Please instead use http://crbug.com "Speed>Benchmarks" component for bugs and https://chromium.googlesource.com/catapult for downloading and editing source code..
https://chromium.googlesource.com/catapult
BSD 3-Clause "New" or "Revised" License
1.93k stars 563 forks source link

Update namespaces given new core/ and non-core directory structure #699

Closed catapult-bot closed 9 years ago

catapult-bot commented 9 years ago

Issue by natduca Sunday Dec 21, 2014 at 03:13 GMT Originally opened as https://github.com/google/trace-viewer/issues/699

Care of #693, we have core and extras. We have base/.

But, we have some stuff in tv, some stuff in tracing. What's the right route forward?

catapult-bot commented 9 years ago

Comment by dj2 Monday Dec 22, 2014 at 01:35 GMT

Personally, I like tv for trace-viewer. It's shorter then tracing and closer to the actual name of the project.

catapult-bot commented 9 years ago

Comment by natduca Monday Dec 22, 2014 at 02:06 GMT

That seems promising!

Would rename toplevel folder to be tv? Then you'd have tv.base == tv/base.html, tv.TraceViewer == tv/trace_viewer.html etc

Would core/foo be tv.core.foo?

Would extras/ get prefixed with tv.extras?

catapult-bot commented 9 years ago

Comment by dj2 Monday Dec 22, 2014 at 13:41 GMT

I think that all makes sense but core/foo would be tv.core.foo yea?

catapult-bot commented 9 years ago

Comment by natduca Tuesday Dec 23, 2014 at 01:27 GMT

Derp, yes. I edited my previous post to reflect that. :)

catapult-bot commented 9 years ago

Comment by natduca Friday Dec 26, 2014 at 21:30 GMT

Mostly done except for base. I've called tv/extras/ the tv.e namespace, so tv/base can be tv.b. That'll be my next CL.

catapult-bot commented 9 years ago

Comment by natduca Friday Dec 26, 2014 at 21:59 GMT

Fixed in 5f648c3d0bc33e75de2b8a078b4878c7a016b95e