catapult-project / catapult

Deprecated Catapult GitHub. Please instead use http://crbug.com "Speed>Benchmarks" component for bugs and https://chromium.googlesource.com/catapult for downloading and editing source code..
https://chromium.googlesource.com/catapult
BSD 3-Clause "New" or "Revised" License
1.92k stars 564 forks source link

could we have a "complete async event" like with complete duration event? #960

Open catapult-bot opened 9 years ago

catapult-bot commented 9 years ago

Issue by natduca Saturday May 16, 2015 at 04:11 GMT Originally opened as https://github.com/google/trace-viewer/issues/960


A few folks have tracers that issue tons of async begin/end events. But, the async b and e end up duplicating a ton of data so the file gets le-big. The request from them is that we support a way to create an async event with a single event that contains a ts and a duration, like with 'X'

@xunjieli wdyt? Doable? We woudln't need to expose to chromium trace_event.h, just support it in the importer and update the format docs...

catapult-bot commented 9 years ago

Comment by dj2 Sunday May 17, 2015 at 13:51 GMT


You'd also have to output the process/thread that each of those things started on, otherwise, why not just use an X event?

Something like:

{ph:'Y', stid:5, etid:6, spid:1, epid:2, name:'blah', ts:123, dur:24, ...}

Is there anything else that would be needed?

catapult-bot commented 9 years ago

Comment by xunjieli Monday May 18, 2015 at 15:43 GMT


Yes, it is doable. I can help with modifying the importer code if you decided to go with this route. What's the difference between tts and ts? "tts" is not explained in the docs, and it isn't very clear on what it does in the code either. Anyone knows?

catapult-bot commented 9 years ago

Comment by DavidYen Monday May 18, 2015 at 17:15 GMT


I believe ts is "timestamp" while tts is "thread timestamp". You can use tts to figure out how much time was actually spent running that thread.

On Mon, May 18, 2015 at 8:43 AM Helen Li notifications@github.com wrote:

Yes, it is doable. I can help with modifying the importer code if you decided to go with this route. What's the difference between tts and ts? "tts" is not explained in the docs https://docs.google.com/document/d/1CvAClvFfyA5R-PhYUmn5OOQtYMH4h6I0nSsKchNAySU/edit#heading=h.yr4qxyxotyw, and it isn't very clear on what it does in the code either. Anyone knows?

— Reply to this email directly or view it on GitHub https://github.com/google/trace-viewer/issues/960#issuecomment-103108581 .

catapult-bot commented 9 years ago

Comment by xunjieli Monday May 18, 2015 at 17:25 GMT


Makes sense. Thanks for the clarification!