search

catavallejos / BASiCS

BASiCS: Bayesian Analysis of Single-Cell Sequencing Data. This is an unstable experimental version. Please see http://bioconductor.org/packages/BASiCS/ for the official release version
84 stars 17 forks source link

v2.3.2, no error for single batch #226

Closed alanocallaghan closed 3 years ago

alanocallaghan commented 3 years ago

Same as the other PR but for devel

codecov-io commented 3 years ago

Codecov Report

Merging #226 (27e0c34) into master (effdd00) will decrease coverage by 0.09%. The diff coverage is 90.90%.

:exclamation: Current head 27e0c34 differs from pull request most recent head b1fd092. Consider uploading reports for the commit b1fd092 to get more accurate results Impacted file tree graph

@@            Coverage Diff             @@
##           master     #226      +/-   ##
==========================================
- Coverage   91.31%   91.22%   -0.10%     
==========================================
  Files          48       48              
  Lines        4203     4181      -22     
==========================================
- Hits         3838     3814      -24     
- Misses        365      367       +2
Impacted Files Coverage Δ
R/BASiCS_PriorParam.R 100.00% <ø> (ø)
R/utils_MCMC.R 89.68% <78.26%> (-0.02%) :arrow_down:
R/BASiCS_DivideAndConquer.R 97.56% <100.00%> (-0.12%) :arrow_down:
R/BASiCS_MCMC.R 100.00% <100.00%> (ø)
R/BASiCS_MockSCE.R 100.00% <100.00%> (ø)
R/utils_Data.R 60.78% <100.00%> (-0.76%) :arrow_down:
R/utils_DivideAndConquer.R 89.34% <100.00%> (+1.00%) :arrow_up:
src/updates.h 89.68% <0.00%> (-0.32%) :arrow_down:
src/MCMCNoSpikes.h 98.74% <0.00%> (-0.08%) :arrow_down:
src/MCMC.h 98.85% <0.00%> (-0.07%) :arrow_down:
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update f1e98a6...b1fd092. Read the comment docs.

catavallejos commented 3 years ago

@Alanocallaghan just realised there was a second PR. Is this ready to be merged too? The two check errors are due to a small difference in the coverage of the unit tests, so I think it should be ok.

Before I merge, could you please update NEWS?

alanocallaghan commented 3 years ago

Yep, same content. The other was for release, this is devel (just bug fixes in both cases). just did news