Init fails if any s0 is exactly zero

catavallejos / BASiCS

BASiCS: Bayesian Analysis of Single-Cell Sequencing Data. This is an unstable experimental version. Please see http://bioconductor.org/packages/BASiCS/ for the official release version

84 stars 17 forks source link

Init fails if any s0 is exactly zero #227

Closed alanocallaghan closed 3 years ago

alanocallaghan commented 3 years ago

Because 0/0 is NaN

https://github.com/catavallejos/BASiCS/blob/f1e98a63897cadcc3df722c111a26315a4b6bf4d/R/utils_MCMC.R#L158

alanocallaghan commented 3 years ago

scran::calculateSumFactors already sets positive=TRUE by default so our current fix is not great. Should use scran::cleanSizeFactors instead I think

alanocallaghan commented 3 years ago

https://github.com/LTLA/scuttle/issues/9

alanocallaghan commented 3 years ago

Fixed upstream but I'll keep the safety check just in case