search

catc / react-timekeeper

Google Keep app inspired time picker for react :clock4:
https://catc.github.io/react-timekeeper
MIT License
696 stars 67 forks source link

Please update the following components: Clock, ClockWrapper, StyleRoot, StyleSheet, Time, Timepicker #53

Closed lazzyms closed 4 years ago

lazzyms commented 4 years ago

Warning:Legacy context API has been detected within a strict-mode tree.

The old API will be supported in all 16.x releases, but applications using it should migrate to the new version.

Please update the following components: Clock, ClockWrapper, StyleRoot, StyleSheet, Time, Timepicker

Removing <React.StrictMode></React.StrictMode> supress the error but it renders default component, not the one I have modified with adding props or css and also not able to change the value.

Versions: React: 16.13.1 react-timekeeper: 2.1.1

catc commented 4 years ago

I updated the react version and tested with strictmode but I can't reproduce the warnings. The package shouldn't be using any legacy context. Can you try updating your package and see if it's still an issue?

catc commented 4 years ago

Closing for now - will reopen if it's still an issue.