catchorg / Clara

A simple to use, composable, command line parser for C++ 11 and beyond
Boost Software License 1.0
648 stars 67 forks source link

Clara: TextFlow: added iterator traits #75

Closed JoeyGrajciar closed 5 years ago

JoeyGrajciar commented 5 years ago

Added iterator traits for Column::iterator and also Columns::iterator These will allow using of these iterators in stl algorithms.

codecov[bot] commented 5 years ago

Codecov Report

Merging #75 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #75   +/-   ##
=======================================
  Coverage   94.72%   94.72%           
=======================================
  Files           2        2           
  Lines         683      683           
=======================================
  Hits          647      647           
  Misses         36       36
Impacted Files Coverage Δ
include/clara_textflow.hpp 98.42% <ø> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update a19db09...5654241. Read the comment docs.

philsquared commented 5 years ago

Thanks @JoeyGrajciar. I've applied this to the TextFlowCpp project:

https://github.com/philsquared/textflowcpp/commit/41226fcf07148adb2827c72f12a1980beddc692d

I'll get that merged into Clara soon.

JoeyGrajciar commented 5 years ago

@philsquared thank you :) Closing this pull request