search

catchorg / Clara

A simple to use, composable, command line parser for C++ 11 and beyond
Boost Software License 1.0
648 stars 67 forks source link

Fixed some warnings + added new warnings for unit tests #83

Open n3rdswithgame opened 5 years ago

n3rdswithgame commented 5 years ago

This is not really a major change, but it helps out for any project that tries to build without any warnings like I do.

Added -Wshadow and -Wsign-conversion warnings to the gcc + clang warnings for the test suite. GCC does not turn these on by default with -Wall or -Wextra, and I don't know if clang bundles them the added warnings in its -Wall or -Wextra.

Also fixed a few lines in the headers that raised these warnings, namely appending an underscore for the shadow warning and a static cast to the sign conversion warning. I went with the underscore on the arguments as I figured there was a good reason that the TokenStream::it and TokenStream::itEnd members didn't have an m_ prefix.