catchpoint / WebPageTest.agent-install

Automated scripts for installing dedicated wptagent instances
Apache License 2.0
10 stars 25 forks source link

Fix missing repo for ttf-mscorefonts-installer #21

Closed klodr closed 1 year ago

pmeenan commented 1 year ago

I'd be hesitant to do this universally. Maybe put it behind a uname check and only add it for straight-up debian bullseye distributions. As far as I can tell, it's in the default repo's for Ubuntu (which will automatically handle 18.04, 20.04 and 22.04). I don't know what effects there would be in enabling the debian bullseye repo for other debian-based distributions (or non-bullseye debian).

klodr commented 1 year ago

Yes indeed. I intentionally left it as a draft as my try was only on a standard GCE: WPT_CLOUD=gce bash <(curl -s https://raw.githubusercontent.com/WPO-Foundation/wptagent-install/master/debian.sh) Also missing :

  1. sudo apt-key adv --keyserver keyserver.ubuntu.com --recv-keys EF4186FE247510BE
  2. sudo apt-key adv --keyserver keyserver.ubuntu.com --recv-keys 9BDB3D89CE49EC21
  3. seems there are many outdated repositories too : some from bullseye and some still from stretch ?
  4. Still installing PHP 7.2 outdated two years ago https://www.php.net/supported-versions.php
  5. And finally there is problem with dependencies probably linked to the above mentioned outdated repositories.
  6. Duplicate repositories etc...

A lot of changes there and above my technical level !