catchpoint / WebPageTest.agent-install

Automated scripts for installing dedicated wptagent instances
Apache License 2.0
10 stars 25 forks source link

Chrome + Edge Install Fails #22

Closed jdarnton-akamai closed 1 year ago

jdarnton-akamai commented 1 year ago

Line 323 wget -q -O - https://www.webpagetest.org/keys/google/linux_signing_key.pub | sudo apt-key add -

results in

Warning: apt-key is deprecated. Manage keyring files in trusted.gpg.d instead (see apt-key(8)).
gpg: no valid OpenPGP data found.

and the script fails. However if you run wget -q -O - https://dl.google.com/linux/linux_signing_key.pub | sudo apt-key add -

the results are

Warning: apt-key is deprecated. Manage keyring files in trusted.gpg.d instead (see apt-key(8)).
OK

and the script can continue.

jdarnton-akamai commented 1 year ago

Appears Edge install fails in the same way for the same reason.

pmeenan commented 1 year ago

Trying to track down what happened to the proxy code in the main WebPageTest www code. It used to rewrite those /keys/* requests and proxy them to the relevant origin (serving from cache for a while) to allow for installing in networks that blocked dl.google.com (China for example).

@tkadlec in case it rings a bell.

pmeenan commented 1 year ago

Either way, looks like those should all be changed to point to the direct keys for now and if it becomes a problem, figure it out then.

jdarnton-akamai commented 1 year ago

Created pull request for this: https://github.com/WPO-Foundation/wptagent-install/pull/23