search

catchpoint / WebPageTest.agent

Cross-platform WebPageTest agent
Other
213 stars 138 forks source link

Fixing headers and other indicators for proxied resources #492

Closed tkadlec closed 2 years ago

tkadlec commented 2 years ago

This brings back headers, render blocking indicators, unused preloads, etc for URL's that get intercepted thanks to overrideHost

pmeenan commented 2 years ago

LGTM. Only nit is that proxiedUrl implies that the host override was for proxying. It's a common use case but not necessarily the only reason the host was substituted. Not sure if it is worth bikeshedding on the name but maybe overriddenUrl or rewrittenUrl

tkadlec commented 2 years ago

Good call. I'll swap that.