catchpoint / WebPageTest.agent

Cross-platform WebPageTest agent
Other
213 stars 138 forks source link

Add Safari desktop support #582

Closed pmeenan closed 1 year ago

pmeenan commented 1 year ago

This adds support for testing Safari desktop without the need for an extension (was problematic to build, sign and install). It should "just work" once the Mac OS agents are updated and "Safari" is added to the list of browsers for the given location.

Sample result is here.

The biggest thing that doesn't work is that the requests do not have URL's because the Safari logs (which are used to gather the request details) don't have URLs or headers but it does have all of the granular timing details so we can see a lot of things we couldn't see before (like wait time).

What DOES work:

When WebDriver bidi becomes available then we should get better access to the per-request details but that's probably still a ways out.

pmeenan commented 1 year ago

Tried using resource timing to match request URLs but the data in resource timings is not unique enough to reliably match the requests from the logs so for now the requests will have to be without real URLs.