search

catchpoint / WebPageTest.agent

Cross-platform WebPageTest agent
Other
210 stars 138 forks source link

Logging fixes #640

Closed pmeenan closed 10 months ago

pmeenan commented 10 months ago

This changes the rfc5424 logging to only be imported when that mode of logging is being used and also adds an (optional) requirement for the tzlocal module which is required by the rfc5424 logging code.

This way the agents that are already deployed should install the module if it's not already on the systems.

Without these changes, the agents are likely to stop working as soon as they update unless tzlocal is installed on them (not part of the default install script).

pmeenan commented 10 months ago

Thanks. Added pytz to the module installs and also updated the in-agent install script. It was a little less critical because it was pre-installed on the ubuntu images I was using but better safe than sorry.

pmeenan commented 10 months ago

@mjkozicki could you merge when you get a chance (I'm not authorized for the agent - which I'm good with keeping that way)