search

catchpoint / WebPageTest.visual-metrics

Calculate visual performance metrics from a video (Speed Index, Visual Complete, Incremental progress, etc)
BSD 3-Clause "New" or "Revised" License
153 stars 46 forks source link

Added unit test. #4

Closed zwri closed 9 years ago

zwri commented 9 years ago

Implemented misc cleanups to support Linux. Added a basic unit test.

pmeenan commented 9 years ago

I just pulled in all of the relevant fixes except for the unit test. Let me know if that still looks good and I can pull that in as well. The rest should be ready to go though.

zwri commented 9 years ago

Thanks. I had to move the tests to straighten out the import paths. I'm not sure why my merge 8d054a2 looks so ugly; I think you can simply cherry-pick the "Move test*" 48fdd30.

pmeenan commented 9 years ago

I pulled in the unit tests. I had to make a small change to the test_exec one to explicitly call python because it wouldn't work on Windows othwerwise but let me know if that breaks something on your end. The import test didn't work on Windows either (ImportError: cannot import name visualmetrics) but I'll worry about that in a bit.

zwri commented 9 years ago

LGTM.