catchpoint / WebPageTest

Official repository for WebPageTest
Other
3.07k stars 714 forks source link

Add traffic shaping verification to agent and/or server #169

Closed zwri closed 2 years ago

zwri commented 10 years ago

Add NodeJS agent and/or WPT server-side code to verify that the traffic shaper is working as intended.

Basically, post-process the DevTools/HAR/Waterfall to verify that the Time-to-First-Byte is < the desired latency, the throughput is < the desired bwIn/out, etc -- check for "network too fast". Similarly, add rough checks for "network too slow", though this should be more forgiving than "too fast". Use a fudge-factor in case the event timing is slightly off.

I'm not sure if it's best to implement this in the agent, the server, or both -- there are pros/cons to each. (e.g. "both" is duplicate effort)

This would have detected a recent bug where our network was mis-wired: even though the agent correctly invoked ipfw, the packets weren't flowing through the host & therefore weren't being shaped.

tkadlec commented 2 years ago

We're in the process of cleaning up issues on this project in order to ensure we're able to stay on top of high priority bugs and feature requests.

As a part of this process, we're automatically closing any issues that have had no activity within the last two years, including this one, since the codebase has changed dramatically in that time.

If you feel this is still relevant, please file a new issue using the relevant issue template so we can get it prioritized.

Thanks!