search

catchpoint / WebPageTest

Official repository for WebPageTest
Other
3.06k stars 709 forks source link

og:image needs updating. #2304

Closed henrihelvetica closed 1 year ago

henrihelvetica commented 1 year ago

Description

the og:image is the old logo and simply needs to be updated to the new one. The oldie is showing up when test results are shared (noticed in Slack).

scottjehl commented 1 year ago

Hey @henrihelvetica

Thanks. Do you know which page this showed up on? og:image should reference our screenshotter and be updated at least for new urls. Maybe it was one that was older? Homepage currently has this:

stoyan commented 1 year ago

Looks like the page needs to declare $useScreenshot = true; for the cool screenshots, otherwise we fallback to <meta property="og:image" content="/images/social-logo.jpg"> e.g. in test history page https://www.webpagetest.org/testlog/7/

stoyan commented 1 year ago

Hacked something together, just resized one of the newer assets we have to match the original 1200x630 social-logo

scottjehl commented 1 year ago

great stuff. approved the PR